Aau/#7/huri script architecture #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popochounet
requested review from
MatthiasvonRakowski and
thomas-pommier-epi
src/main.py
Outdated
| time.sleep(2) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
Contributor
There was a problem hiding this comment.
Pourquoi enlever la fonction main ?
| self._running = True | ||
| self.poller.start() | ||
|
|
||
| def _poll_loop(self) -> None: |
Contributor
There was a problem hiding this comment.
Pas contre d'avoir des petits commentaire sous les méthodes ou le nom n'est pas super claire
MatthiasvonRakowski
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModuleManager (launch router and modules, handle logging) use case
Shell as a ModuleManager entrypoint
EventRouter
logging added
Sample modules (WIP)