Fix #17: Warn when provided argument name in ArgumentException is incorrect #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nameof operator for argument name
| } | ||
|
|
||
| [Test] | ||
| public void ShouldWarnOnArgumentExceptionHasStringParameterNameInMethod() { |
Owner
There was a problem hiding this comment.
I think explicit test case and even special message would be highly useful (but maybe not part of this PR) when user uses different order of arguments - throw ArgumentExcpetion("name", "message").
Author
There was a problem hiding this comment.
I can see at least 4 different cases here:
throw new ArgumentException("name", "message")- your casethrow new ArgumentException("name", "name")- the name of the argument is used as description (probably valid). Also, it can be `throw new ArgumentException("name", nameof(name))throw new ArgumentException("name1", "name2")- the name of one argument is used as description, the other one is used as parameter (both are valid names)throw new ArgumentException("name", variable)- variable can provide required name
There may be more, but even those add 4 additional rules. Looks more like additional task to me.
Owner
There was a problem hiding this comment.
Definitely. Out of scope for this task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.