Skip to content

Conversation

@lopert
Copy link
Contributor

@lopert lopert commented Jan 30, 2026

Background

v2.0.1 was released, which addresses the realm error during buildGraphQLTypes, and now our templates should use it.

Solution

Our templates are hardcoded to use 2.0.0. This PR bumps them to a minimum of 2.0.1, and also makes them grab the latest 2.X version.

Tophat 🎩

shopify app init --flavor=javascript --template=reactRouter --package-manager=pnpm --name js2-0-1-tester
cd js2-0-1-tester
shopify app generate extension --template=discount --flavor=vanilla-js --name test-discount-function-old-package

(^ this should fail, showing the problem)

shopify app generate extension --template=discount --flavor=vanilla-js --name test-discount-function-new-package -u https://github.com/Shopify/extensions-templates.git\#lopert.update-functions-js-package

(^ this should succeed, showing the fix)

Please run through the tophat with other templates as well. (i.e. cart_checkout_validation, cart_transform, payment_customization)

Checklist

  • I have 🎩'd these changes
  • I have squashed my commits into chunks of work with meaningful commit messages

@lopert lopert merged commit 0616bfb into main Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants