-
Notifications
You must be signed in to change notification settings - Fork 378
feat: add shopify-dev preview automation workflow #3356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
majd-shopify
wants to merge
14
commits into
2025-05
Choose a base branch
from
feat/add-shopify-dev-preview-automation-workflow
base: 2025-05
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: add shopify-dev preview automation workflow #3356
majd-shopify
wants to merge
14
commits into
2025-05
from
feat/add-shopify-dev-preview-automation-workflow
+126
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
0b3cf8b to
3d66720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shopify-dev preview automation workflow
WHY are these changes introduced?
Part of https://github.com/Shopify/shopify-dev/issues/66722
We need to add a workflow in Hydrogen that detects changes to gen docs files. If there are any, and the base branch name adheres to the config of gendocs in shopify dev, it will dispatch a shopify-dev workflow which then grabs those changes, and creates a new branch in shopify-dev with those changes in them.
Additionally this workflow will only run for authorized shopify org authors
WHAT is this pull request doing?
Adds the workflow mentioned above!
Here is a link of the workflow running https://github.com/Shopify/hydrogen/actions/runs/20859038193/job/59933554739?pr=3356 however, the workflow it's trying to dispatch is not merged to main yet in shopify-dev
This change will need to go to
mainand synced across all branches. But currently it is on this branch for testing purposes. Base will change tomainonce approved and done.Workflow diagram:
HOW to test your changes?
Review https://github.com/Shopify/hydrogen/actions/runs/20859038193/job/59933554739?pr=3356
Post-merge steps
This just needs to be in main, nothing else.
Checklist