ShopPayButton now accepts storeDomain prop #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lordofthecactus
commented
Mar 6, 2023
|
|
||
| const ShopifyContext = createContext<ShopifyContextValue>({ | ||
| export const defaultShopifyContext: ShopifyContextValue = { | ||
| storeDomain: 'test', |
Contributor
Author
There was a problem hiding this comment.
Noticed that this makes all uses of useShop() to contain this default parameters. I would suggest to remove this and make it null by default. This is why in the step above I had to check if storeDomain was the default or not.
Contributor
Author
|
Added @juanpprieto in a commit since I copied some of this code from: Shopify/hydrogen-react#122 |
lordofthecactus
force-pushed
the
dr/shop-pay-without-provider
branch
from
d59f285 to
46080f9
Compare
Contributor
Author
|
Working oxygen deployment at: https://bwcgr1r9v-f1f4fa724b7467f41f07.myshopify.dev/ |
Co-authored-by: Juan P. Prieto <juanpablo.prieto@shopify.com>
This reverts commit 6023e83.
lordofthecactus
force-pushed
the
dr/shop-pay-without-provider
branch
from
bc1563e to
62c5df0
Compare
wizardlyhel
approved these changes
Mar 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShopPayButton can now receive a storeDomain prop. Updated the demo store to make it work.
WHY are these changes introduced?
Part of: #629
Solves:
#487
HOW to test your changes?
Go to a product in the demo store and click on Shop Pay button. It should open the Shop checkout
Post-merge steps
There are other component relying on
ShopifyProviderChecklist