Fix filter error translation for context evaluate of variable expression #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
approved these changes
Feb 9, 2021
dylanahsmith
added a commit
that referenced
this pull request
Feb 9, 2021
Fix filter error translation for context evaluate of variable expression (cherry picked from commit dd2909b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#115 fixed ArgumentError translation for Liquid::Variable#render, but Liquid::Context#evaluate was still doing a direct function call in C to the implementation of Liquid::C::Expression#evaluate. As a result, the error was still not being translated properly.
Solution
The first commit refactors the variable expression evaluation to provide an internal_variable_expression_evaluate function for context.c.
The second commit fixes the bug by checking the class in context_evaluate to call internal_variable_expression_evaluate for a cLiquidCVariableExpression.