Skip to content

Conversation

@dylanahsmith
Copy link
Contributor

Problem

Adding a # inline comment tag for Shopify/liquid#1393 requires changing the parsing code to recognize that as a tag.

Solution

Change the code path for where no word characters are found for tag name, so this shouldn't even impact the performance of handling non-comment tags.

@samdoiron
Copy link
Contributor

samdoiron commented Apr 22, 2022

I'm seeing a test failure in Liquid here when combined with this branch

    assert_template_result('2', '{{ list[foo] }}', 'foo' => IntegerDrop.new('1'), 'list' => [1, 2, 3])

Source

This looks unrelated, though. Perhaps a bug on main?

@samdoiron
Copy link
Contributor

This may also be because the branches are out of date, checking that now.

@dylanahsmith dylanahsmith merged commit 629377c into master Apr 28, 2022
@dylanahsmith dylanahsmith deleted the inline-comment branch April 28, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants