Stop using Liquid::Expression.parse for integration testing #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since liquid-c no longer monkey patches it, so we need a higher-level tests to ensure they are shared across liquid implementations.
dylanahsmith
commented
Aug 31, 2022
samdoiron
approved these changes
Sep 1, 2022
dylanahsmith
force-pushed
the
expression-integration-test
branch
from
a6a46ab to
98c11e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Shopify/liquid-c#179 to fix the test errorProblem
liquid-c stopped patching Liquid::Expression.parse in Shopify/liquid-c#178 since it was too implicit, so integration tests using Liquid::Expression.parse weren't actually being shared across implementations.
Solution
Use assert_template_result and assert_match_syntax_error for integration testing, which will better enable us to share tests using it across liquid implementations.