This repository was archived by the owner on Jan 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 225
Update formatName and abbreviateName to return a string or undefined
#2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 View this PR in Shipit Next. ℹ️ Expand to learn how to deploy and handle emergencies using Shipit NextOverviewShipit Next will merge your code on your behalf because this repository uses Shipit Next and its merge queue. To ship this PR, you can either:
Comment Commands
Commands exclusive to Deploy Before Merge
Documentation
Questions or feedback?
|
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @trishrempel! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/name": "0.0.0-snapshot-20250108144406",
"@shopify/react-i18n": "0.0.0-snapshot-20250108144406",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20250108144406" |
3282fcf to
f9084dc
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @trishrempel! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/name": "0.0.0-snapshot-20250108150133",
"@shopify/react-i18n": "0.0.0-snapshot-20250108150133",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20250108150133" |
jesstelford
approved these changes
Jan 10, 2025
Contributor
jesstelford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
formatName(and through dependencyabbreviateName) to returnstring | undefinedrather than a blank string if any of the provided inputs do not yield a valid non-empty value.Already merged in https://github.com/Shopify/quilt-internal/pull/31