Add compiler for Rails.env methods #2450
Merged
+177
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Dec 17, 2025
spec/tapioca/dsl/compilers/active_support_environment_inquirer_spec.rb
Outdated
Show resolved
Hide resolved
bdewater-thatch
force-pushed
the
rails-env-compiler
branch
from
2acb47d to
afd1a7a
Compare
Contributor
Author
|
@KaanOzkan I addressed your feedback, PTAL |
KaanOzkan
approved these changes
Dec 19, 2025
Contributor
|
Opened #2453 for CI failures |
bdewater-thatch
force-pushed
the
rails-env-compiler
branch
from
afd1a7a to
b21b01e
Compare
Contributor
Author
|
This has been rebased since CI has been fixed. PTAL and happy new year! |
amomchilov
approved these changes
Jan 5, 2026
Contributor
amomchilov
left a comment
amomchilov
left a comment
There was a problem hiding this comment.
Very thorough, thanks for contributing this!
Two small requests and I'm good to merge
lib/tapioca/dsl/compilers/active_support_environment_inquirer.rb
Outdated
Show resolved
Hide resolved
bdewater-thatch
force-pushed
the
rails-env-compiler
branch
from
b21b01e to
a6e070f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Why spend 10 seconds manually typing up shims if I can spend 10 minutes writing a compiler? Across all Tapioca users the math checks out: https://xkcd.com/1205/
Implementation
I figured DEFAULT_ENVIRONMENTS can be skipped since https://github.com/Shopify/rbi-central/blob/7d98e7310d9ac5c6d34a48c05fb74f75dfc2d4ef/rbi/annotations/activesupport.rbi#L8-L21 already covers these.