Fix css selector, center the size element, and wait one second for GitHub to finish loading #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub changed its HTML in the last three years, which broke the CSS selector in constants.ts.
Immediately after a pjax event is ready, GitHub does something to its UI that causes adding the size element to fail. Waiting 1 second and then trying to add the element again seems to work.
Quipyowert2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS selector has not been updated in the past three years. GitHub has changed the class of the statistics element, which caused the size stat to not show up at all. I fixed that, then noticed the size element was not centered vertically. Fixed that, and then it doesn't show up when switching either between branches or when switching from the main page of a repository (Code tab) and the Issues tab and then back.
The code in the third commit uses a combination of a
MutationObserverandsetIntervalto keep trying to add the element every second after injectRepoSize() is called during a AJAX event.