Use board number instead of address in the Mercury class #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbespin
reviewed
Mar 17, 2025
basil/HL/mercury.py
Outdated
| A protocoll via RS 232 serial port is used with 9600/19200/38400/115200 baud rate. The baud rate | ||
| can be set with dip switches, as well as a hardware address to distinguish several | ||
| devices on one line. The write termination is CR and the read ends with '\r', '\n', '\x03'. | ||
| devices on one line. Keep in mind that the address that is set via the DIP switches corresponds to (board number + 1). Check p.45 of the overall manual below on how to properly set the address of each controller and what the corresponding board number is. The write termination is CR and the read ends with '\r', '\n', '\x03'. |
Contributor
There was a problem hiding this comment.
We do not enforce line break rules, but can you change this to reflect the line length of the others, please?
basil/HL/mercury.py
Outdated
Comment on lines
31
to
35
| self._addresses = [] | ||
| for a in range(16): # Check all possible addresses | ||
| self.write(bytearray.fromhex("01%d" % (a + 30)) + "TB".encode()) # Tell board address | ||
| if self.get_address(a): | ||
| self._addresses.append(a) | ||
| self._board_numbers = [] | ||
| for b in range(16): # Check all possible board numbers | ||
| self.write(bytearray.fromhex("01%d" % (b + 30)) + "TB".encode()) # Tell board number | ||
| if self.get_board_number(b): | ||
| self._board_numbers.append(b) |
Contributor
There was a problem hiding this comment.
Personally, I refrain from using single-character variables; maybe board_n or even board_number is a bit easier to read. Just wanted to point it out, this is no actual change request. Hit "resolve" if you want to keep it as it is.
cbespin
approved these changes
Mar 17, 2025
Contributor
cbespin
left a comment
cbespin
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237