Skip to content

Conversation

@JasZhe
Copy link
Contributor

@JasZhe JasZhe commented Apr 10, 2025

Addresses the suggestion made in #186 (the last comment), but maybe doesn't exactly fix the root issue.

I had this as an advice for a while, but figured I'd try to upstream it

@Silex
Copy link
Owner

Silex commented Apr 10, 2025

Thanks! That looks nice. I wonder if local or local-only would make more sense than non-remote.

I understand it matches better with the (not (file-remote-p code but from the user perspective I feel our brain are better wired to reason with X rather than "not Y".

positive assertions are easier to understand than negatives
@JasZhe
Copy link
Contributor Author

JasZhe commented Apr 10, 2025

Yeah good point

@Silex Silex merged commit 75a5716 into Silex:main Apr 11, 2025
22 checks passed
@Silex
Copy link
Owner

Silex commented Apr 11, 2025

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants