-
Notifications
You must be signed in to change notification settings - Fork 47
Adding test for EP coupling 1D to 3D mesh #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
+ Coverage 67.52% 67.72% +0.19%
==========================================
Files 169 169
Lines 32671 32671
Branches 5728 5728
==========================================
+ Hits 22062 22127 +65
+ Misses 10472 10407 -65
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kko27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good test case to me! I think we should include documentation on this coupling feature in our multi physics documentation website: https://simvascular.github.io/documentation/multi_physics.html
|
|
||
| <Add_projection name = "fc_efib"> | ||
| <Project_from_face> endo </Project_from_face> | ||
| <Projection_tolerance> -1.0 </Projection_tolerance> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was curious about what setting -1.0 does to this projection_tolerance parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this parameter is set to a negative value, the code looks for the nearest neighbor, regardless of how far it is. If it is a positive value, the code will only accept nearest neighbors below that value. In this case we need every node to be matched, so we used a negative value (if not some nodes would not be coupled)
|
@ktbolt can you take a look at this? Thanks! |
ktbolt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
Current situation
resolves #474
Release Notes
svMultiPhysics/tests/cases/cep/cylinder_purkinje_1d3dCode of Conduct & Contributing Guidelines