Skip to content

Conversation

@javijv4
Copy link

@javijv4 javijv4 commented Nov 26, 2025

Current situation

resolves #474

Release Notes

  • AddedsvMultiPhysics/tests/cases/cep/cylinder_purkinje_1d3d

Code of Conduct & Contributing Guidelines

@javijv4 javijv4 changed the title Dev #474 Adding test for EP coupling 1D to 3D mesh Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.72%. Comparing base (2f17399) to head (d2b0846).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   67.52%   67.72%   +0.19%     
==========================================
  Files         169      169              
  Lines       32671    32671              
  Branches     5728     5728              
==========================================
+ Hits        22062    22127      +65     
+ Misses      10472    10407      -65     
  Partials      137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javijv4 javijv4 requested review from kko27 and ktbolt December 16, 2025 22:17
Copy link
Contributor

@kko27 kko27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good test case to me! I think we should include documentation on this coupling feature in our multi physics documentation website: https://simvascular.github.io/documentation/multi_physics.html


<Add_projection name = "fc_efib">
<Project_from_face> endo </Project_from_face>
<Projection_tolerance> -1.0 </Projection_tolerance>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious about what setting -1.0 does to this projection_tolerance parameter?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this parameter is set to a negative value, the code looks for the nearest neighbor, regardless of how far it is. If it is a positive value, the code will only accept nearest neighbors below that value. In this case we need every node to be matched, so we used a negative value (if not some nodes would not be coupled)

@javijv4
Copy link
Author

javijv4 commented Jan 10, 2026

@ktbolt can you take a look at this? Thanks!

Copy link
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

End nodes are not correctly read in electrophysiology

4 participants