Skip to content

Conversation

@dlansigan
Copy link
Contributor

Current situation

Resolves #455

Release Notes

  • Remove second declaration of divV, which was causing divergence=0.0 bug for 3D fluid simulations.
  • Updated reference files for tests with new divergences.

Code of Conduct & Contributing Guidelines

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.60%. Comparing base (2f17399) to head (8f38977).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   67.52%   67.60%   +0.07%     
==========================================
  Files         169      169              
  Lines       32671    32673       +2     
  Branches     5728     5729       +1     
==========================================
+ Hits        22062    22087      +25     
+ Misses      10472    10447      -25     
- Partials      137      139       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aabrown100-git aabrown100-git self-requested a review January 7, 2026 22:35
Copy link
Collaborator

@aabrown100-git aabrown100-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aabrown100-git
Copy link
Collaborator

@dlansigan Before closing and merging, could you create another issue about the actual divergence values and whether they are expected (as I mentioned here)

@dlansigan dlansigan closed this Jan 8, 2026
@dlansigan dlansigan reopened this Jan 8, 2026
@aabrown100-git aabrown100-git merged commit 2a03051 into SimVascular:main Jan 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Second declaration of divV should be removed in post::div_post

2 participants