Function input feature for time-dependent boundary conditions

[kharold23]

Current situation

Closes #89

Release Notes

• Added a new parameter fn to flow and pressure boundary conditions that takes in a string
• Interprets the string as a function of time, represented by the variable t
• The value of the boundary condition is calculated at each time step by evaluating the function at t = the current time value.

Documentation

Time-dependent boundary conditions can now be input using a function passed in as a string. The function is of the variable t, or time. For example:
"bc_values": { "fn": "2.0 * (4*atan(1.)) * COS(2.0 * (4*atan(1.)) * t)" }

Testing

Test case test_time_dependent_block added to test_io.py, which runs json files timeDep_Flow.json and timeDep_Pressure.json.

Code of Conduct & Contributing Guidelines

• I agree to follow the Code of Conduct and Contributing Guidelines.

[ktbolt]

I ran the pulsatileFlow_CStenosis_steadyPressure case on Ubuntu 22 and got the following exception

terminate called after throwing an instance of 'std::runtime_error'
  what():  Maximum number of non-linear iterations reached.

You need to add catching exceptions in the Python testing code.

[ktbolt]

We don't want to mix external software with our source code so the exprtk.hpp file should not be in svZeroDSolver/src/. We need to add a ThirdParty directory and put the exprtk.hpp file in a sub-directory of it.

[ktbolt]

Also I see that there is Docker container file in svZeroDSolver/container/profiling for Ubuntu 22, you can use this to test I think.

[codecov]

Codecov Report

Attention: Patch coverage is 74.69880% with 21 lines in your changes missing coverage. Please review.

Project coverage is 25.12%. Comparing base (688cece) to head (e6760c6).

Files	Patch %	Lines
src/solve/SimulationParameters.cpp	73.80%	11 Missing ⚠️
src/model/Parameter.cpp	65.51%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #108       +/-   ##
===========================================
- Coverage   79.25%   25.12%   -54.14%     
===========================================
  Files          52       53        +1     
  Lines        2179    15401    +13222     
  Branches      278     1405     +1127     
===========================================
+ Hits         1727     3869     +2142     
- Misses        452    11532    +11080     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[menon-karthik]

Almost ready! Just some minor comments.

[mrp089]

@menon-karthik can this be merged?

[mrp089]

@menon-karthik, @ncdorn, do you know if this can be merged? I think @szafronjm would be interested in using that

[menon-karthik]

@mrp089 This is currently stalled because we could not figure out why one of the tests is failing. But it can be used by directly pulling the feature branch for now: https://github.com/kharold23/svZeroDSolver/tree/time-dependent

[ArashPartow]

@menon-karthik would mind rebasing/synching this branch to the tip and giving it another go - as the test results seem to have disappeared.

[ncdorn]

we should rebase this branch and figure out if it can be merged @kharold23 @menon-karthik

[ncdorn]

I will close this as I have taken over this PR on my own fork and have opened the draft pull request #186 to handle these changes.