Skip to content

Conversation

@mrp089
Copy link
Member

@mrp089 mrp089 commented Nov 25, 2025

Current situation

We don't have automatic code formatting for .json files. This makes it hard to compare whether test case results changed between commits (see, e.g., #203).

Release Notes

  • Added Prettier to format .json files automatically
  • Added to the makefile make codeformat and make codecheck commands
  • Added to GitHub workflow

Documentation

Added documentation to the developer guide un running .json formatting and automatically formatting everything Visual Studio Code on saving.

Testing

Formats as intended. Actions are running, documentation builds.

Code of Conduct & Contributing Guidelines

@mrp089 mrp089 requested a review from ncdorn November 25, 2025 15:07
@KatrinKoesler KatrinKoesler requested review from KatrinKoesler and removed request for ncdorn December 1, 2025 16:23
Copy link
Collaborator

@KatrinKoesler KatrinKoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mrp089 mrp089 merged commit 54ecc45 into SimVascular:master Dec 1, 2025
10 checks passed
@mrp089 mrp089 deleted the format_json branch December 1, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants