Skip to content

MS-1288 PR check optimisation (simple stuff) #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 4 commits into from
Jan 14, 2026
Merged

MS-1288 PR check optimisation (simple stuff) #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f36833
MS-1288 Cancel in-progress runs when a new commit is pushed to the PR
luhmirin-s Jan 13, 2026
37d4b2b
MS-1288 Update the PR-check pull_request trigger
luhmirin-s Jan 13, 2026
5fd015c
MS-1280 Run all test tasks in a single gradle command
luhmirin-s Jan 13, 2026
c140d48
MS-12188 Do not run sonar checks if PR is in draft
luhmirin-s Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,22 @@ on: # this checks should be triggered on pull request, before deployments, and m
pull_request:
paths-ignore:
- 'infra/resources/src/main/res/**'
- '**.md'
types:
# Default types of PR triggers
- opened
- reopened
- synchronize
# Ensures that Sonar check are run once PR is ready
- ready_for_review
workflow_call:
workflow_dispatch:

# Cancel in-progress runs when a new commit is pushed to the PR
concurrency:
group: pr-checks-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
core-unit-tests:
name: Core Unit Tests
Expand Down Expand Up @@ -146,3 +159,5 @@ jobs:
fingerprint-unit-tests,
testing-tools ]
uses: ./.github/workflows/reusable-sonar-scan.yml
# Only run if the PR ready for review or triggered manually
if: github.event.pull_request.draft == false || github.event_name == 'workflow_dispatch'
25 changes: 14 additions & 11 deletions .github/workflows/reusable-run-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,23 @@ jobs:
- name: Run tests
run: |
# Get the modules array from the previous step
modules_array=("${{ steps.create-modules-array.outputs.modules_array}}")
modules_array=(${modules_array// / })
# Iterate over the array
modules_array=(${{ steps.create-modules-array.outputs.modules_array }})
# Transform input list into a single string of gradle tasks
TASKS=""
for module in "${modules_array[@]}"; do
echo -e "\n\n"
echo "=========================================="
echo "=========================================="
echo " Test $module"
echo "=========================================="
echo "=========================================="
echo -e "\n\n"
./gradlew $module:jacocoTestReport
if [ -n "$module" ]; then
TASKS="$TASKS $module:jacocoTestReport"
fi
done

echo -e "\n\n"
echo "=========================================="
echo "=========================================="
echo "Executing Gradle tasks: $TASKS"
echo "=========================================="
echo "=========================================="
echo -e "\n\n"
./gradlew $TASKS --continue --no-daemon
- name: Upload Folders
uses: actions/upload-artifact@v6
with:
Expand Down