Initial review #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe-s
force-pushed
the
review/initial
branch
from
b195bf6 to
104413e
Compare
TristramN
requested changes
Nov 13, 2024
Contributor
TristramN
left a comment
TristramN
left a comment
There was a problem hiding this comment.
For the unit testing:
- Could we have a more specific class and function name
- We don't assert on the final function calls
- We should test each unit separately, and then have a final integration test. The current test is more of an integration test. But ideally, we should have 1 unit test per function on the Poly protect object. Since this PR is for 2 commits that don't cover the unit test I can't point to it directly sorry! But we want one test for
transformTemplateone forgenerateSecretAuxDataRecordand one forcomputeScore
Contributor
|
@gstrag readme and SDs look good! |
gstrag
force-pushed
the
review/initial
branch
from
225a0f0 to
788af94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://simprints.atlassian.net/browse/BIO-564?atlOrigin=eyJpIjoiZmVlYTRiZDliNDI4NGE2N2JmODM5YTA0MTJkODkzZmMiLCJwIjoiaiJ9. Please review readme / sequence diagrams.
https://simprints.atlassian.net/browse/BIO-551?atlOrigin=eyJpIjoiM2ZjNjQxZTM0MzA4NDgxYTk3MTA1YTdiZDk1Y2NmY2UiLCJwIjoiaiJ9. Please review unit tests.