Kotlinifying the repository #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luhmirin-s
commented
Nov 29, 2024
luhmirin-s
commented
- Made code more idiomatic
- Changed class and property names to follow the code style conventions
- Removed unnecessary subjectId argument that was being passed around for no apparent reason
- Refactored global static variables to be instance properties instead
- Updated tests to do more meaningful assertions using appropriate functions
- Changed the root package to adhere to Java/Kotlin convention to avoid issues for clients when importing the library
- Embedded some of the documentation in KDocs in code to be available in IDE hints
- Cleaned up project setup from most of the Android-specific stuff, could do one more step and make this into a pure Kotlin library without any Android dependencies
* Changed class and property names to follow the code style conventions * Removed unnecessary subjectId value that was being passed around for no apparent reason * Refactored global static variable use to be instance properties instead * Updated tests to do more meaningful assertions using correct functions
* Changed the package to adhere to java/kotlin conventions to avoid build tooling issues in future * Cleaned up unnecessary android-specific cofnig from build gradle file
…instead of README
gstrag
approved these changes
Dec 2, 2024
Contributor
|
Awesome, thanks Sergejs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.