Array converter fix #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luhmirin-s
commented
Mar 20, 2025
luhmirin-s
commented
- Changed the AuxData to use IntArray directly to avoid confusion around conversions
- Changed the encoding logic to expect a byte stream of float array
- Added the computation tests to ensure that all parts work correctly together
- Also used the opportunity to align the API levels and tooling versions with SID
Thinkorswim
reviewed
Mar 20, 2025
Thinkorswim
left a comment
Thinkorswim
left a comment
There was a problem hiding this comment.
Looks good to me!
Do we need to make any changes in the readme?
Contributor
Author
I did not find any references to the methods in the readme file. JavaDoc comments are very explicit on the contents of the byte arrays, which should be sufficient, IMO. |
gstrag
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.