Skip to content

Fix crash on ASCII area due to buffer overrun #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliasaraf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash on ASCII area due to buffer overrun #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/qhexedit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,11 +995,16 @@ void QHexEdit::paintEvent(QPaintEvent *event)
if (_editAreaIsAscii)
{
// every 2 hex there is 1 ascii
int ch = (uchar)_dataShown.at(hexPos / 2);
if (ch < ' ' || ch > '~')
ch = _defaultChar;
int asciiPos = hexPos / 2;
// The cursor can go out of the currently displayed data
if (asciiPos < _dataShown.size())
{
int ch = (uchar)_dataShown.at(asciiPos);
if (ch < ' ' || ch > '~')
ch = '.';

painter.drawText(_pxCursorX - pxOfsX, _pxCursorY, QChar(ch));
painter.drawText(_pxCursorX - pxOfsX, _pxCursorY, QChar(ch));
}
}
else
{
Expand Down