Skip to content

Remove const from by-value bool parameters #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eliasaraf wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove const from by-value bool parameters #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/qhexedit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ void QHexEdit::setReadOnly(bool readOnly)
_readOnly = readOnly;
}

void QHexEdit::setHexCaps(const bool isCaps)
void QHexEdit::setHexCaps(bool isCaps)
{
_hexCaps = isCaps;
viewport()->update();
Expand All @@ -325,7 +325,7 @@ bool QHexEdit::hexCaps() const
return _hexCaps;
}

void QHexEdit::setDynamicBytesPerLine(const bool isDynamic)
void QHexEdit::setDynamicBytesPerLine(bool isDynamic)
{
_dynamicBytesPerLine = isDynamic;
resizeEvent(nullptr);
Expand Down
4 changes: 2 additions & 2 deletions src/qhexedit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,10 @@ public slots:
QByteArray data();
void setData(const QByteArray &ba);

void setHexCaps(const bool isCaps);
void setHexCaps(bool isCaps);
bool hexCaps() const;

void setDynamicBytesPerLine(const bool isDynamic);
void setDynamicBytesPerLine(bool isDynamic);
bool dynamicBytesPerLine() const;

bool highlighting() const;
Expand Down