Skip to content

Conversation

@sourcery-ai
Copy link

@sourcery-ai sourcery-ai bot commented Jul 15, 2020

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Comment on lines -62 to +65
newVAdata = {}
for velocity in self.VAdata:
newVAdata[velocity*constant] = self.VAdata[velocity]*constant
newVAdata = {
velocity * constant: self.VAdata[velocity] * constant
for velocity in self.VAdata
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function DrivingSchedule.rescaleVA refactored with the following changes:

  • Convert for loop into dictionary comprehension (dict-comprehension)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jul 15, 2020

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.01 out of 10.

Before After Change
Quality 8.91 8.92 0.01
Complexity 1.07 1.0 -0.07
Method Length 40.25 39.97 -0.29
Lines 109 110 1
Changed files Quality Before Quality After Quality Change
DrivingCycle.py 8.91 8.92 0.01 ⬆️

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant