Skip to content

Workflow Improvements #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtarun1 merged 37 commits into from
Jun 25, 2025
Merged

Workflow Improvements #18

rtarun1 merged 37 commits into from
Jun 25, 2025

Conversation

@eccentricOrange
Copy link
Member

@eccentricOrange eccentricOrange commented May 31, 2025

  • stop using keyservers so that builds can happen on IIIT-H Wi-Fi also
  • use the $ROS_DISTRO variable in some places where humble was hardcoded
  • implement CI/CD for building images

@eccentricOrange
Copy link
Member Author

eccentricOrange commented Jun 2, 2025

Key migration guide

https://discourse.ros.org/t/ros-signing-key-migration-guide/43937

@eccentricOrange
Copy link
Member Author

eccentricOrange commented Jun 2, 2025 •
edited
Loading

Please note that the workflow is hard-coded to use the testing tag as of 09fe993

This has to be changed to the version number before merging anything

Edit: fixed

@eccentricOrange eccentricOrange force-pushed the workflow-improvements branch 2 times, most recently from ba740a9 to b9b6ae8 Compare June 7, 2025 11:13
@eccentricOrange eccentricOrange force-pushed the workflow-improvements branch from cfd31de to 06301ce Compare June 8, 2025 07:36
@eccentricOrange eccentricOrange changed the title IIIT-H Wi-Fi issue fix and CI/CD Workflow Improvements Jun 8, 2025
@eccentricOrange eccentricOrange self-assigned this Jun 8, 2025
@eccentricOrange eccentricOrange requested a review from rtarun1 June 8, 2025 07:39
@eccentricOrange eccentricOrange linked an issue Jun 8, 2025 that may be closed by this pull request
Update key setup #19
Closed
@eccentricOrange eccentricOrange added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jun 8, 2025
@rtarun1 rtarun1 merged commit f0ddecf into master Jun 25, 2025
@rtarun1
Copy link
Member

rtarun1 commented Jun 25, 2025

LGTM, TYSM @eccentricOrange !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtarun1 rtarun1 Awaiting requested review from rtarun1

Assignees

@eccentricOrange eccentricOrange

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update key setup

3 participants

@eccentricOrange @rtarun1