WWSTCERT-8180/8183/8186 Add support to smart sirens #2431

marcintyminski · 2025-09-29T08:28:54Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2025-09-29T08:29:21Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-09-29T08:30:07Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/Kr2zdPNoRZjA

github-actions · 2025-09-29T08:32:17Z

Test Results

71 files 481 suites 0s ⏱️
2 496 tests 2 496 ✅ 0 💤 0 ❌
4 299 runs 4 299 ✅ 0 💤 0 ❌

Results for commit 9b15c12.

♻️ This comment has been updated with latest results.

github-actions · 2025-09-29T08:32:19Z

File	Coverage
All files	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-siren/src/frient/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-siren/src/init.lua	`93%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 9b15c12

greens · 2025-09-30T17:54:45Z

drivers/SmartThings/zigbee-siren/src/frient/init.lua

@@ -1,4 +1,4 @@
-- Copyright 2022 SmartThings
+-- Copyright 2025 SmartThings


please leave the copyright date as-is

greens · 2025-09-30T18:07:05Z

drivers/SmartThings/zigbee-siren/src/frient/init.lua

+  if compObj then
+    if component == "SirenVolume" then
+      device:set_field("sirenVolume", mode_set, {persist = true})
+    elseif component == "SirenVoice" then
+      device:set_field("sirenVoice", mode_set, {persist = true})
+    elseif component == "SquawkVolume" then
+      device:set_field("squawkVolume", mode_set, {persist = true})
+    elseif component == "SquawkVoice" then
+      device:set_field("squawkVoice", mode_set, {persist = true})
+    end
+  end


you should be able to use device:get_latest_state rather than setting these redundant fields

greens · 2025-09-30T18:11:01Z

drivers/SmartThings/zigbee-siren/src/test/test_frient_siren.lua

I'd recommend a test of the lifecycle events where PRIMARY_SW_VERSION isn't already set to mirror what the flow would look like for a new device join.

greens

When the profile of a fingerprint is changed, already-installed devices do not switch the profile they're using.

I'm worried that these changes will break functionality for those already installed devices (which will lack the new components). I expect this is the case, and why the test_frient_siren test had to be updated.

I might suggest that you keep the fingerprint and original handler the same, other than adding a read of the fw version, then add a sub-driver that checks that value or the new model names.

greens · 2025-09-30T18:18:13Z

drivers/SmartThings/zigbee-siren/profiles/frient-siren-battery-source-tamper.yml

+metadata:
+  mnmn: SmartThingsCommunity
+  vid: 6f595ea0-8f76-3a67-9e4f-e51ffdad970f


We discourage custom metadata for WWST profiles. Can you elaborate on what is being included here?

greens · 2025-10-16T18:35:07Z

Checking drivers/SmartThings/zigbee-siren/src/test/test_frient_siren.lua 1 warning

    drivers/SmartThings/zigbee-siren/src/test/test_frient_siren.lua:42:7: (W211) unused variable IASZONE_ENDPOINT

Checking drivers/SmartThings/zigbee-siren/src/test/test_frient_siren_tamper.lua 1 warning

    drivers/SmartThings/zigbee-siren/src/test/test_frient_siren_tamper.lua:42:7: (W211) unused variable IASZONE_ENDPOINT

You also have failing tests.

…Smart-Sirens

greens · 2025-10-20T22:24:32Z

drivers/SmartThings/zigbee-siren/src/init.lua

+    mode,
+    battery,
+    refresh


your additions here are causing the tests in test_zigbee_siren to fail, as the test was not written with these defaults included.

you'll need to update these tests

…Smart-Sirens

greens · 2025-11-18T19:51:36Z

drivers/SmartThings/zigbee-siren/profiles/frient-siren-battery-source.yml

+  - id: WarningDuration
+    capabilities:
+      - id: mode
+        version: 1
+preferences:
+  - title: "Alarm duration (s)"
+    name: warningDuration


Can you explain the difference between the WarningDuration component and the warningDuration preference? They seem like they might come into conflict.

The WarningDuration mode is made to expose it in UI to make routines more configurable (along other modes). The goal was to create routines with different siren behavior for different triggering events. The preference allows user to input the exact value for the alarm duration, but is not applicable to routines.

Can't they have different values, though? Can't that cause conflicts?

Please answer this question.

I have not explained it well. The warningDuration from preferences should be named maxWarningDuration as it is max duration the siren can be turned on. So if the mode WarningDuration is set to for example 2 minutes, but preference warningDuration is set to 1 minute, then the siren will be on for 1 minute.

So they can interact, and one can limit the other. If you're determined to keep both, would it be possible, then, to change the supported values for WarningDuration's mode attribute to only include values below the preference value? And also to change the wording of the preference to indicate it's a maximum value?

I still think it's confusing, and only having one would be ideal, but I think the current situation with both can be improved a little bit.

greens · 2025-11-18T19:53:29Z

drivers/SmartThings/zigbee-siren/src/test/test_frient_siren.lua

-  "Capability(alarm) command(both) on should be handled",
-  {
-    {
-      channel = "capability",
-      direction = "receive",
-      message = { mock_device.id, { capability = "alarm", component = "main", command = "both", args = { } } }
-    },
-    {
-      channel = "zigbee",
-      direction = "send",
-      message = { mock_device.id, IASWD.server.commands.StartWarning(mock_device,
-                                                                            SirenConfiguration(0xC1),
-                                                                            data_types.Uint16(0x00B4),
-                                                                            data_types.Uint8(00),
-                                                                            data_types.Enum8(00)) }
-    }
-  }


Can you tell me what this command would have done for the older siren?

I'm very uncomfortable changing functionality like this, which is why I recommended a sub-driver based on the firmware version to change these sorts of commands.

It has been decided to not use the both command. However if it was used, the bit operations would change the SirenConfiguration so that bits 7 and 6 would store the siren volume value (0b11), bits 5 and 4 would store strobe value (0b00) and last 4 bits would store mode value. In this case that would mean that the siren would be turned on in mode 1 with the volume 3 and no strobe.

…Smart-Sirens

Add support to smart sirens

9675ff5

greens reviewed Sep 30, 2025

View reviewed changes

greens changed the title ~~Add support to smart sirens~~ WWSTCERT-8183/8186 Add support to smart sirens Oct 16, 2025

Merge branch 'SmartThingsCommunity:main' into Add-support-for-frient-…

6b8e933

…Smart-Sirens

greens reviewed Oct 20, 2025

View reviewed changes

marcintyminski and others added 6 commits October 27, 2025 09:51

Merge branch 'SmartThingsCommunity:main' into Add-support-for-frient-…

7c7e03e

…Smart-Sirens

Add duration and adjust according to pr comments

8336f06

correct typo

e0a6a54

Merge branch 'SmartThingsCommunity:main' into Add-support-for-frient-…

d38409d

…Smart-Sirens

Changed test files

1b1710f

removed duplicated function

5471c19

KKlimczukS requested a review from greens November 17, 2025 09:12

greens reviewed Nov 18, 2025

View reviewed changes

Merge branch 'SmartThingsCommunity:main' into Add-support-for-frient-…

78ad883

…Smart-Sirens

greens changed the title ~~WWSTCERT-8183/8186 Add support to smart sirens~~ WWSTCERT-8180/8183/8186 Add support to smart sirens Dec 1, 2025

marcintyminski and others added 3 commits January 5, 2026 08:41

Merge branch 'SmartThingsCommunity:main' into Add-support-for-frient-…

2d8afd4

…Smart-Sirens

change the preference name and warning duration behavior

7e16c0a

remove unused variable

9b15c12

		@@ -1,4 +1,4 @@
		-- Copyright 2022 SmartThings
		-- Copyright 2025 SmartThings

WWSTCERT-8180/8183/8186 Add support to smart sirens #2431

Are you sure you want to change the base?

WWSTCERT-8180/8183/8186 Add support to smart sirens #2431

Uh oh!

Conversation

marcintyminski commented Sep 29, 2025

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens commented Oct 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Sep 29, 2025 •

edited

Loading

github-actions bot commented Sep 29, 2025 •

edited

Loading

greens Nov 18, 2025 •

edited

Loading