WWSTCERT-9096 Ct clamp driver wwsm #2552

petewaddy-petewaddy · 2025-11-13T18:56:23Z

Check all that apply

Type of Change

[x ] WWST Certification Request
- If this is your first time contributing code:
  - [ x] I have reviewed the README.md file
  - [ x] I have reviewed the CODE_OF_CONDUCT.md file
  - [ x] I have signed the CLA
- [x ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
[x ] New feature
Refactor

Checklist

[ x] I have performed a self-review of my code
[ x] I have commented my code in hard-to-understand areas
[x ] I have verified my changes by testing with a device or have communicated a plan for testing
[x ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

add a sub driver to the standard edge driver for Zigbee Power meter to supply temperature and battery percentage readings

Summary of Completed Tests

Smartthings full 14 test test suite from the certification console, all 14 tests passed

Test date: 13 November 2025 at 11:28:28
Test duration: 00:12:27
Session ID: WHJ1WLTHID

Test date: 13 November 2025 at 11:51:55
Test duration: 00:09:10
Session ID: 1DIHUP08CV

pegor-karoglanian · 2025-11-25T18:11:54Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+
+local function battery_level_handler(driver, device, value, _zb_rx)
+  if type(value.value) == "number" then
+  local number = value.value/2


now corrected

PR SmartThingsCommunity#2552 indent code under the statement to the right as per pull request comment

pegor-karoglanian

lgtm

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

github-actions · 2025-12-01T20:44:09Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-12-01T20:44:36Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/QLMOo6AG0KM3

greens · 2025-12-01T20:44:42Z

drivers/SmartThings/zigbee-power-meter/fingerprints.yml

+  - id: "ChameleonCTClamp"
+    deviceLabel: Zigbee CT
+    deviceIdentifiers:
+      - 0x000D
+    zigbeeProfiles:
+      - 0x0104
+    clusters:
+      server:
+        - 0x0000 #Basic
+        - 0x0001 #Power Configuration
+        - 0x0002 #Device Temperature Configuration
+        - 0x0003 #Identify
+        - 0x0019 #Over the Air Bootloading
+        - 0x0020 #Poll Control
+        - 0x0702 #Simple Metering
+        - 0x0B04 #Electrical Measurement
+      client:
+        - 0x0003 #Identify
+    deviceProfileName: ct-clamp    
+
+


Please just include the manufacturer-specific fingerprint

other fingerprints now removed

greens · 2025-12-01T20:44:51Z

.gitignore

changes to this file should be omitted

github-actions · 2025-12-01T20:45:29Z

Test Results

71 files 469 suites 0s ⏱️
2 457 tests 2 457 ✅ 0 💤 0 ❌
4 177 runs 4 177 ✅ 0 💤 0 ❌

Results for commit e04499e.

github-actions · 2025-12-01T20:45:30Z

File	Coverage
All files	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua	`77%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/shinasystems/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua	`73%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/configurations.lua	`95%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against e04499e

drivers/SmartThings/zigbee-power-meter/profiles/power-energy-battery-temperature.yml

greens · 2025-12-01T20:47:30Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+  local batt_level = device:get_latest_state("main", capabilities.battery.ID, capabilities.battery.battery.NAME) or nil
+  if batt_level == nil then
+    device:emit_event(capabilities.battery.battery.normal())
+  end


I would expect this to go in added. Is there a reason you included it in init?

now removed as unnecessary

greens · 2025-12-01T20:50:54Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+local function battery_level_handler(driver, device, value, _zb_rx)
+  if type(value.value) == "number" then
+    local number = value.value/2
+    local integer_result = math.floor(number)
+    device:emit_event(capabilities.battery.battery(integer_result))
+  else
+      log.error("Invalid battery level value received: " .. tostring(value.value))
+  end
+end
+
+local function temperature_handler(driver, device, value, _zb_rx)
+  if type(value.value) == "number" then
+    device:emit_event(capabilities.temperatureMeasurement.temperature({ value = value.value, unit = "C" }))
+  else
+      log.error("Invalid temperature value received: " .. tostring(value.value))
+  end
+end


if you just added battery and temperatureMeasurement here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-power-meter/src/init.lua#L53

You could omit most of this file.

We've moved battery but temperatureMeasurement wasn't possible to move as we think it's a different ZCL temperature attribute from a different cluster to what you were thinking of @greens but we may have missed something?

You are correct. I see now that you are using clusters.DeviceTemperatureConfiguration rather than clusters.TemperatureMeasurement, so you are correct, that is not handled by our defaults.

greens · 2025-12-01T20:51:46Z

Checking drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua 2 warnings

    drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua:2:7: (W211) unused variable cluster_base
    drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua:3:7: (W211) unused variable data_types

greens

Please address the remaining comments.

wkhenon · 2025-12-05T21:24:36Z

drivers/SmartThings/zigbee-power-meter/fingerprints.yml

+
+
+


Suggested change

made suggested change and removed newlines

wkhenon · 2025-12-05T21:27:55Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+  {model = "CT101xxxx" }
+}
+
+-- temperature: 0.5C, battery level remaining: 1%


Is this comment still needed?

now removed

greens · 2025-12-13T20:32:29Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+  for _, fingerprint in ipairs(ZIGBEE_FINGERPRINT) do
+      if device:get_model() == fingerprint.model then
+         return true
+      end
+  end


nit: spacing

adjusted spacing

greens · 2025-12-13T20:33:56Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+  {
+    cluster = PowerConfiguration.ID,
+    attribute = PowerConfiguration.attributes.BatteryPercentageRemaining.ID,
+    minimum_interval = 30,
+    maximum_interval = 3600,
+    data_type = PowerConfiguration.attributes.BatteryPercentageRemaining.base_type,
+    reportable_change = 2
+  }


I recommend that you omit this and use the defaults here, which has a maximum_interval of 6 hours and a reportable change of 1.

omitted and using defaults

greens · 2025-12-13T20:34:11Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+local function battery_level_handler(driver, device, value, _zb_rx)
+  if type(value.value) == "number" then
+    local number = value.value/2
+    local integer_result = math.floor(number)
+    device:emit_event(capabilities.battery.battery(integer_result))
+  else
+      log.error("Invalid battery level value received: " .. tostring(value.value))
+  end
+end


since you are using the defaults here now, this function can be removed

function removed

greens · 2025-12-13T20:34:42Z

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua

+  if type(value.value) == "number" then
+    device:emit_event(capabilities.temperatureMeasurement.temperature({ value = value.value, unit = "C" }))
+  else
+      log.error("Invalid temperature value received: " .. tostring(value.value))


Please remove this log statement.

log statement removed

petewaddy-petewaddy · 2025-12-15T15:18:41Z

Last 4 comments have been actioned.
Device tested, working as expected.
ran the WWST 14 point test suite , passed as below

Test summary for Chameleon CT Clamp

Congratulations! Your product passed the test and no issues were detected with your product.
Test date: 15 December 2025 at 11:43:07
Test duration: 00:10:38
Session ID: 3L1W0P48DR
Device Profile: power-energy-battery-temperature (3fd2150c-62d6-3df7-9389-0ccceb843096)
Driver: Zigbee Power/Meter (1c09b903-7601-48cf-9a5b-8e3bb0e63b90)

greens · 2025-12-16T17:08:56Z

You'll need to rebase your branch to resolve the merge conflicts.

petewaddy-petewaddy · 2025-12-16T20:02:52Z

Regarding the conflicts the fingerprints.yml is just an additional of chameleon along side the BITUO TECHNIK entry.

but my init.lua originally had

sub_drivers = {
require("ezex"),
require("frient"),
require("shinasystems"),
require("chameleon"),
},

but currently the current master/main has sub_drivers = require("sub_drivers"), with a new file sub_drivers.lua and also a new file lazy_load_subdriver.lua

this looks like a newer feature for sub drivers, I am right in assuming I will need to implement this before we can merge?

…driver for temperature, battery percentage e

battery seems to always be at 100% on both tested clamps, even throiugh one is as 98%

Now calling the ct clamp sub driver - have temperature,battery,power meter and energy meter on the screen, last two are correct values, first two are not as yet

…nd deployed to the hub, using the standard smartthings zigbee power meter as the base and adding as a sub driver the temperature and battery level

PR SmartThingsCommunity#2552 indent code under the statement to the right as per pull request comment

rename file from ct-clamp.yml to power-energy-battery-temperature.yml add copyright information

removed unused variables cluster_base and data_types

add changed name into yaml file remove non manufacturer specific items

Added longer copyright at top of our init.lua file removed comment about tempeature and battery removed battery level handler to main init.lua file under capabilities.battery, temperature syayed as its cluster 0x0402 not the normal temperature cluster and didn't update the temperature

removed 3 lines as requested in comments on the pull request

remove unintentional extra line in .gitignore

add new line, that was erased by accicent in these two files

trying to insert a new line at the end of the file to remove the red circle in github, when the file is checked in

remove battery percentage config, and use defaults remove battery_level_handler as usinf the capabilites function remove log function in temperature handler adjust spacing in is_chameleon_ct_clamp function

after a rebase add in the chameleon entry into the sub_drivers.lua file

after a rebase add in the chameleon entry into the sub_drivers.lua file add in the new files can_handle.lua and fingerprints.lua, for the new type of sub driver architecture

greens requested review from greens, pegor-karoglanian and wkhenon November 25, 2025 18:04

greens changed the title ~~Ct clamp driver wwsm~~ WWSTCERT-9096 Ct clamp driver wwsm Nov 25, 2025

pegor-karoglanian reviewed Nov 25, 2025

View reviewed changes

petewaddy-petewaddy added a commit to petewaddy-petewaddy/SmartThingsEdgeDrivers that referenced this pull request Nov 26, 2025

WWSTCERT-9096

e04499e

PR SmartThingsCommunity#2552 indent code under the statement to the right as per pull request comment

pegor-karoglanian approved these changes Nov 26, 2025

View reviewed changes

greens reviewed Dec 1, 2025

View reviewed changes

drivers/SmartThings/zigbee-power-meter/src/chameleon/init.lua Show resolved Hide resolved

greens reviewed Dec 1, 2025

View reviewed changes

.gitignore

Copy link

Contributor

greens Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to this file should be omitted

wkhenon reacted with thumbs up emoji

greens reviewed Dec 1, 2025

View reviewed changes

drivers/SmartThings/zigbee-power-meter/profiles/power-energy-battery-temperature.yml Show resolved Hide resolved

greens reviewed Dec 1, 2025

View reviewed changes

greens reviewed Dec 5, 2025

View reviewed changes

wkhenon reviewed Dec 5, 2025

View reviewed changes

greens reviewed Dec 13, 2025

View reviewed changes

petewaddy-petewaddy added 3 commits December 18, 2025 10:21

no workspace files in repo

99414a8

start of using zigbee powerr meter as the main and then adding a sub …

d282e74

…driver for temperature, battery percentage e

first pass, after help from gemini.

4cdbb7b

battery seems to always be at 100% on both tested clamps, even throiugh one is as 98%

petewaddy-petewaddy added 19 commits December 18, 2025 11:41

Another attempt

dcbf755

Now calling the ct clamp sub driver - have temperature,battery,power meter and energy meter on the screen, last two are correct values, first two are not as yet

first pass of what seems to be a fully working sub driver, packaged a…

1ce9f0b

…nd deployed to the hub, using the standard smartthings zigbee power meter as the base and adding as a sub driver the temperature and battery level

Changes to copied in values for temperature and battery percentage

44c6d06

remove reference to VS code workspace

2380426

set back to origin code

1f81fe1

no message

018061b

cr lf

181fadb

WWSTCERT-9096

ef5dcce

PR SmartThingsCommunity#2552 indent code under the statement to the right as per pull request comment

ct-clamp-driver-wwsm

b9858a3

rename file from ct-clamp.yml to power-energy-battery-temperature.yml add copyright information

ct_clamp-driver_wwsm

7c5ee13

removed unused variables cluster_base and data_types

ct_clamp_river_wwsm

a41c51b

add changed name into yaml file remove non manufacturer specific items

removed as causing error in the HUB log

038660c

ct_clamp_driver_wwsm

aa4e241

removed 3 lines as requested in comments on the pull request

ct_clamp_driver_wwsm

1a032d9

remove unintentional extra line in .gitignore

ct_clamp_driver_wwsm

6df0a94

add new line, that was erased by accicent in these two files

ct_clamp_driver_wwsm

6dd2028

trying to insert a new line at the end of the file to remove the red circle in github, when the file is checked in

ct_clamp_driver_wwsm

c940d2d

remove battery percentage config, and use defaults remove battery_level_handler as usinf the capabilites function remove log function in temperature handler adjust spacing in is_chameleon_ct_clamp function

ct_clamp_driver_wwsm

0638d49

after a rebase add in the chameleon entry into the sub_drivers.lua file

petewaddy-petewaddy force-pushed the ct_clamp_driver_wwsm branch from 171237c to 0638d49 Compare December 18, 2025 11:57

petewaddy-petewaddy and others added 2 commits December 18, 2025 16:11

ct_clamp_driver_wwsm

e16d6a6

after a rebase add in the chameleon entry into the sub_drivers.lua file add in the new files can_handle.lua and fingerprints.lua, for the new type of sub driver architecture

Merge branch 'main' into ct_clamp_driver_wwsm

dce40f5

WWSTCERT-9096 Ct clamp driver wwsm #2552

Are you sure you want to change the base?

WWSTCERT-9096 Ct clamp driver wwsm #2552

Uh oh!

Conversation

petewaddy-petewaddy commented Nov 13, 2025

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pegor-karoglanian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 1, 2025

Test Results

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens commented Dec 1, 2025

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petewaddy-petewaddy commented Dec 15, 2025

Uh oh!

greens commented Dec 16, 2025

Uh oh!

petewaddy-petewaddy commented Dec 16, 2025

Uh oh!