Add support for Irrigation System device type #2684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the Irrigation System device type, introduced with Matter 1.5.
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 481 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 00cad14. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 00cad14 |
nickolas-deboom
commented
Jan 5, 2026
|
|
||
| SwitchFields.operational_state_command_map = { | ||
| [clusters.OperationalState.commands.Pause.ID] = "pause", | ||
| [clusters.OperationalState.commands.Resume.ID] = "resume" |
Contributor
Author
There was a problem hiding this comment.
Note that only pause and resume (and not start or stop) are supported for Irrigation System by the spec
nickolas-deboom
commented
Jan 5, 2026
| capabilities: | ||
| - id: valve | ||
| version: 1 | ||
| - id: level |
Contributor
Author
There was a problem hiding this comment.
Note that in 66bf122 I reimplemented level as an optional capabilty in this profile (as well as added flowSensor + operationalState). I think this makes sense but let me know if you agree with this approach or not
system This commit adds support for optional clusters: * OperationalState * FlowMeasurement Additionally, the level, operationalState, and flowSensor capabilities are supported via modular profiling.
nickolas-deboom
force-pushed
the
feature/irrigation-system
branch
from
66bf122 to
00cad14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the Irrigation System device type, introduced with Matter 1.5.