Skip to content

AjaxUtils Delete Method data parameter #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlgn2 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

AjaxUtils Delete Method data parameter #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/common-utils/src/implementations/AxiosAjaxUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,20 @@ export class AxiosAjaxUtils implements IAxiosAjaxUtils {

public delete<T>(
url: URL,
data?:
| string
| Record<string, unknown>
| ArrayBuffer
| ArrayBufferView
| URLSearchParams,
config?: IRequestConfig,
): ResultAsync<T, AjaxError> {
return ResultAsync.fromPromise(
this.instance.delete(this.stripTrailingSlash(url.toString()), config),
this.instance.delete(
this.stripTrailingSlash(url.toString()),
data,
config,
),
(e) => {
const err = e as IAxiosError;
if (err.response != null) {
Expand Down
11 changes: 10 additions & 1 deletion packages/common-utils/src/interfaces/IAxiosAjaxUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,16 @@ export interface IAxiosAjaxUtils {
| URLSearchParams,
config?: IRequestConfig,
): ResultAsync<T, AjaxError>;
delete<T>(url: URL, config?: IRequestConfig): ResultAsync<T, AjaxError>;
delete<T>(
url: URL,
data?:
| string
| Record<string, unknown>
| ArrayBuffer
| ArrayBufferView
| URLSearchParams,
config?: IRequestConfig,
): ResultAsync<T, AjaxError>;
setDefaultToken(token: JsonWebToken): void;
}

Expand Down
6 changes: 6 additions & 0 deletions packages/core/test/mock/utilities/AjaxUtilsMock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ export class AjaxUtilsMock implements IAxiosAjaxUtils {
}
public delete<T>(
url: URL,
data?:
| string
| Record<string, unknown>
| ArrayBuffer
| ArrayBufferView
| URLSearchParams,
config?: IRequestConfig | undefined,
): ResultAsync<T, AjaxError> {
throw new Error("Method not implemented.");
Expand Down