Skip to content

Conversation

@SnickerdoodleCTO
Copy link
Contributor

Release Notes

JIRA Link

Summary:

This PR will be "Version 3" of the on-chain protocol. A number of breaking changes will be created to the contract layer.

  1. Removal of Crumbs contract
  2. Removal of Sift Contract
  3. Removal of MinimalForwarder and and EIP-2771 from protocol
  4. Refactored consent contract constructor
  5. Refactored optin functions with new identity commitment storage variable
  6. New convenience functions for fetching all necessary consent contract information in 1 RPC request.

Intended results:

  • Simpler contract architecture overall
  • Hopefully cheaper to call opt in
  • Support for zkp proof of membership
  • less remote requests from core package to read necessary info from on-chain protocol

Potential Failures:

  • potentially not any cheaper to call optin due to new identity commitment storage variable

Relevant Metrics/Indicators:

  • try out npx hardhat test in contracts package to see gas profiling

Testing Notes:

  • This is still a draft PR and not ready for testing yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants