Fix: generatePKCECodeVerifier length #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2025 14:32
…> 128 in length - adds pkceCodeVerifierLength to customize the code_verifier length
ADmad
reviewed
Aug 27, 2025
src/OAuth2/AbstractProvider.php
Outdated
|
|
||
| protected bool $pkce = false; | ||
|
|
||
| protected int $pkceCodeVerifierLength = 96; |
Contributor
There was a problem hiding this comment.
Can we rename this to pkceCodeVerifierByteLength to be more clear about what length it indicates?
Author
There was a problem hiding this comment.
Yes, that will make it more understandable. I also renamed it in the generatePKCECodeVerifier method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug fix |
new feature|code quality|documentationLink to issue: #198
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Thanks 😺