Skip to content

Automated tests #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mvanbrab merged 19 commits into from
Feb 27, 2025
Merged

Automated tests #30

mvanbrab merged 19 commits into from
Feb 27, 2025

Conversation

@NuttyShrimp
Copy link
Collaborator

@NuttyShrimp NuttyShrimp commented Sep 6, 2024 •
edited
Loading

  • Adds playwright test
  • Adds github action on default branch + Pr's to development branch

closes #23

@NuttyShrimp NuttyShrimp force-pushed the automated-tests branch 2 times, most recently from d7c0ebb to 9ac4143 Compare September 6, 2024 09:55
@NuttyShrimp NuttyShrimp marked this pull request as ready for review September 6, 2024 12:07
@NuttyShrimp NuttyShrimp requested a review from bjdmeest September 6, 2024 12:08
@NuttyShrimp NuttyShrimp marked this pull request as draft September 6, 2024 12:19
@NuttyShrimp NuttyShrimp force-pushed the automated-tests branch 3 times, most recently from 961821b to d4c3fff Compare September 6, 2024 14:34
@NuttyShrimp
Copy link
Collaborator Author

NuttyShrimp commented Sep 6, 2024

It seems there is an issue in chromium where the datatable doesn't rerender when the new data is retrieved. But in firefox is rerenders perfectly.
I've tried to add v-model to the value of the table & setting the selectedEntry to a whole new object when I refresh the permissions but without any luck.
It's very strange that in only happens when data is removed but not when new entries are added to the permissions array

@NuttyShrimp
feat(loama): setup playwright + basic tests
3e6eb2c
@NuttyShrimp
feat(tests): add public permission test
a76e304
@NuttyShrimp
feat(tests): add control permission + navigation tests
76d325d
@NuttyShrimp
feat(ci): add github action
83f0bdf
@NuttyShrimp
docs: update changelog
e5ac3a6
@NuttyShrimp
fix(ci): use docker image + update version in package.json
938be62
@NuttyShrimp
docs: add more test setup documentation
072697f
@NuttyShrimp
test(permissions): disable page caching on pod route
2f854a8
@NuttyShrimp
fix(config): force playwright to run 1 test at a time in one browser
6068e85
@NuttyShrimp
chore(playwright): only test in chromium
3656aeb
@NuttyShrimp
fix(tests): set default timeout high + specific timeout's on expected…
6ddc5b1 
… expect's
@NuttyShrimp
test(permissionTable): add test for disable & delete button
e39d675
@NuttyShrimp
fix(permissionTableSpec): await to make sure pages are updated
40b39e4
@NuttyShrimp
chore: update lock file
5fa7543
@NuttyShrimp
chore: update primevue
26060ab
@NuttyShrimp NuttyShrimp marked this pull request as ready for review November 22, 2024 14:50
@bjdmeest
Copy link

bjdmeest commented Jan 16, 2025

Looks good to me!

@mvanbrab could you rebase and run it locally before deploying it for Onto-DESIDE?

@mvanbrab mvanbrab merged commit 9a1f0f6 into development Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjdmeest bjdmeest Awaiting requested review from bjdmeest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automated testing

4 participants

@NuttyShrimp @bjdmeest @mvanbrab