fix: extra fetch to get storage description #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslabbinck
requested changes
Nov 26, 2024
Collaborator
woutslabbinck
left a comment
woutslabbinck
left a comment
There was a problem hiding this comment.
Works well now for Solid Pods that do not have a pim:storage by default (such as the CSS).
All though, now fetching storages from pods that are not CSS crash now, because of the non existent link header.
Could you change the function listPodUrls or fetchStorageTriple such that these still work?
Personally, I think it makes most sense to update fetchStorageTriple by returning undefined if the link header does not exist. But, it is up to you.
woutslabbinck
approved these changes
Dec 2, 2024
Collaborator
woutslabbinck
left a comment
woutslabbinck
left a comment
There was a problem hiding this comment.
It indeed works as intended now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3