Fix navigation links and JSON data paths #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues with tutorials: 1. Links in navigation missing /NavigationSplitView/ prefix Clicking tutorial in sidebar goes to /tutorials/... (404) Should be: /NavigationSplitView/tutorials/... 2. Tutorial pages showing "page not found" even with correct URL JSON data files contain absolute paths SPA cannot load tutorial data from wrong paths Solution: Fix paths in HTML links AND JSON data files HTML fixes (added): - href="/documentation/" to href="/NavigationSplitView/documentation/" - href="/tutorials/" to href="/NavigationSplitView/tutorials/" JSON fixes (new): - Fix all paths in /data/*.json files - /documentation/, /tutorials/, /images/, /videos/, /downloads/ Now navigation links work correctly and tutorial pages load data properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues with tutorials:
Links in navigation missing /NavigationSplitView/ prefix Clicking tutorial in sidebar goes to /tutorials/... (404) Should be: /NavigationSplitView/tutorials/...
Tutorial pages showing "page not found" even with correct URL JSON data files contain absolute paths SPA cannot load tutorial data from wrong paths
Solution: Fix paths in HTML links AND JSON data files
HTML fixes (added):
JSON fixes (new):
Now navigation links work correctly and tutorial pages load data properly.