SPM #30
SPM #30
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public var body: some View { | ||
| Group { | ||
| if horizontalSizeClass == nil { | ||
| EmptyView() | ||
| } else if horizontalSizeClass == .regular { | ||
| regular() |
There was a problem hiding this comment.
SizeClassAdaptiveView returns EmptyView() when horizontalSizeClass is nil. On macOS the size class environment is always nil, so every usage of this component (e.g., wrapping the color list and inspector in the demo) will render nothing and the app shows a blank window. Since the package declares macOS 14 support, the mac build will be non-functional until one of the content closures is used instead. Consider defaulting to the regular layout when the size class is nil rather than suppressing all output.
Useful? React with 👍 / 👎.
No description provided.