Skip to content

Improve nipapd PID file handling #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
garberg wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve nipapd PID file handling #1349

garberg wants to merge 3 commits into from

Conversation

@garberg
Copy link
Member

@garberg garberg commented Oct 23, 2023

start-stop-daemon kindly pointed out a problem with how nipapd's PID file was handled:

  • Too wide permissions (666, changed to 644)
  • Only matched PID when shutting down nipapd (now also match username)

@garberg garberg self-assigned this Oct 23, 2023
@garberg
backend: Set pid file permissions to 644
49bc64c 
By default the permissions of nipapd's PID file was set to 666. Change
to 644.
@garberg
backend: Make sure to mach user when stopping proc
11390c0 
Pass user to start-stop-daemon when stopping nipapd in init script.
@garberg
ci: Check nipapd status
b746d22
@garberg garberg force-pushed the improve_pid_file_handling branch from 07298ac to b746d22 Compare October 24, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@garberg garberg

Labels

backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@garberg