Skip to content

Conversation

@gdsoumya
Copy link
Contributor

@gdsoumya gdsoumya commented Sep 9, 2024

Fixes #367

tezfin1

tezfin2

tezfin3

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@KevinMehrabi
Copy link
Contributor

Although much better, it's still not precise. We can do better. It should be consistent to every increment of change, within <0.0001% margin variability.(of 100.0000%). Seemless to the onlooker.

image

@gdsoumya
Copy link
Contributor Author

gdsoumya commented Sep 11, 2024

@KevinMehrabi that's how the UI component works, it blends the colors from the edge so a bit of the next color shade seeps into the previous one.

@KevinMehrabi
Copy link
Contributor

KevinMehrabi commented Sep 15, 2024 via email

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya
Copy link
Contributor Author

Updated it with different component

@KevinMehrabi
Copy link
Contributor

KevinMehrabi commented Sep 25, 2024

2 problems but both kind of the same thing:

  1. Even-distribution — It's become very green-dominant. The color doesn't start changing at all until nearly half way
  2. Green needs to gradient too. The current green color is just 1 contiguous shade until it starts going into yellow. it needs to start from a deeper-green and then lighten up to become yellowish.

See example (don't take too literally. this is just something i pulled from google real quick):
image

@KevinMehrabi KevinMehrabi merged commit 2e93705 into main Feb 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Borrow Limit bar - color correction

5 participants