Skip to content

Conversation

@SiddharthV1
Copy link
Contributor

@SiddharthV1 SiddharthV1 commented Oct 23, 2024

  • Formula used for obtaining the available parameter :
    available = totalSupply - totalBorrows - totalReserves.

tezfin-new-tables

Mobile / small width view:

tezfin-new-tables-mobile-2

@KevinMehrabi
Copy link
Contributor

Need to see mobile view as well @SiddharthV1

@SiddharthV1 SiddharthV1 changed the title New tables Two Column View Nov 1, 2024
@KevinMehrabi
Copy link
Contributor

KevinMehrabi commented Nov 6, 2024

For mobile view, the columns should be 1 column, with the lending markets stacked over each other. just as the section above it has been stacked (and should stay stacked). They aren't meant to be condensed 2 columns in mobile. My bad, I should have clarified that.

Moreover, the alignment of mobile view should be such that the user is not scrolling to the right to see the buttons. All info of a row should be visible from the screen, without moving it.
^ IF that is not possible, then the fixed elements of mobile should be the buttons (and the background buffer), as well as the tokens (nd their name and symbol, and background buffer)
^ you can combine that with #363

@KevinMehrabi
Copy link
Contributor

We need to implement sticky behavior for the Token column and the action buttons in the market tables (e.g., Supply, Borrow, etc.) to enhance usability. The Token column should remain fixed on the left, and the action buttons should remain fixed on the right, even when the table scrolls horizontally. This will ensure that users can always see which token they’re interacting with and access the buttons without losing context while scrolling. Use CSS position: sticky for both the column and buttons, with proper left and right offsets. Ensure the parent container allows horizontal scrolling (overflow-x: auto) and test responsiveness to maintain functionality on smaller screens. The sticky elements should have a z-index to stay above scrolling content and a matching background color for seamless integration.

image

image

Also it seems that when brought to mobile view, everything is cramped to the edges, and the margins have been lost for the interior elements. we need to restore those margins.

image

versus

image

@KevinMehrabi KevinMehrabi merged commit c5c6b59 into main Feb 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants