Skip to content

Conversation

@Denish3436
Copy link
Contributor

@Denish3436 Denish3436 commented Oct 6, 2024

This PR solve issue #183

  • [ x] I havd Changed the python_version field from 3.8 to 3.11 in the Pipfile.
  • [ x] Verify that all dependencies are compatible with Python 3.11.

Copy link
Member

@refeed refeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I just run the workflows, seemingly there are some problems with upgrading to 3.11, related to pytest dep

 Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.15/x64/bin/pytest", line 5, in <module>
    from pytest import console_main
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/pytest/__init__.py", line 8, in <module>
    from _pytest._code import ExceptionInfo
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/_code/__init__.py", line 5, in <module>
    from .code import Code
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/_code/code.py", line 55, in <module>
    from exceptiongroup import BaseExceptionGroup
ModuleNotFoundError: No module named 'exceptiongroup'

We need to take a look on how to solve this problem

@Denish3436
Copy link
Contributor Author

hii @refeed The issue seems to be stemming from a missing exceptiongroup module. so i am working on it

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

@refeed
Copy link
Member

refeed commented Oct 15, 2024

Hi @Denish3436 , the test is still failing, we need to take a look again. I'm not really sure what's the root problem of this. The issue seems more complicated than I thought earlier :)

    res = hook_impl.function(*args)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1140, in pytest_cmdline_parse
    self.parse(args)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1494, in parse
    self._preparse(args, addopts=addopts)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1366, in _preparse
    self._initini(args)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1239, in _initini
    rootpath, inipath, inicfg = determine_setup(
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/findpaths.py", line 198, in determine_setup
    rootdir, inipath, inicfg = locate_config(invocation_dir, [ancestor])
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/findpaths.py", line 110, in locate_config
    ini_config = load_config_dict_from_file(p)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/findpaths.py", line 64, in load_config_dict_from_file
    import tomli as tomllib
ModuleNotFoundError: No module named 'tomli'

Ideally, when we update the Python version, we shouldn't add more dependencies, it should work out of the box. The worst case might be we need to upgrade the versions of our direct dependencies that are defined within the Pipfile not the dependencies of our dependencies


[packages]
simplejson = "==3.17.2"
pydash = "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why we need to change this to * ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants