Add support for port and reporting interval #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of cleanup. Added support for hostname:port@interval in the startup, so you can tune how often the reporter runs and the port it communicates on. Renamed classes to be lookout classes. Switched to testng and added a parser test for the hostname parsing. Improved documentation.
Added tests for statsdReporter, verified that the JVM reports non-zero values for everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of cleanup. Added support for hostname:port@interval in the
startup, so you can tune how often the reporter runs and the port it
communicates on.
Renamed classes to be lookout classes. Switched to testng and added a
parser test for the hostname parsing. Improved documentation.