Skip to content

Conversation

@the-Astra
Copy link
Contributor

@the-Astra the-Astra commented Dec 28, 2025

A simple helper function that returns the current specified pool without any 'UNAVAILABLE' values. Takes the same arguments as vanilla's get_current_pool

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

@nh6574
Copy link
Contributor

nh6574 commented Dec 28, 2025

I think it should make a new list instead of replacing all values with nil, no? I also don't think it's good practice to remove values don a table while iterating on it but I assume it works in this case.

@the-Astra
Copy link
Contributor Author

I think it should make a new list instead of replacing all values with nil, no? I also don't think it's good practice to remove values don a table while iterating on it but I assume it works in this case.

Doing a new list is probably better. The reason I did the iteration method is because doing it in a for...in ipairs loop would cause skips on consecutive unavailable objects, but this will be moot when I make it return a new list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants