SMODS.DrawStep Card.draw modularization
#480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GauntletGames-2086
added a commit
that referenced
this pull request
Feb 24, 2025
WilsontheWolf
requested changes
Feb 25, 2025
Co-authored-by: WilsontheWolf <git@shorty.systems>
WilsontheWolf
approved these changes
Feb 28, 2025
GauntletGames-2086
approved these changes
Feb 28, 2025
Member
GauntletGames-2086
left a comment
GauntletGames-2086
left a comment
There was a problem hiding this comment.
Besides one issue, this PR looks good to merge.
Aurelius7309
pushed a commit
that referenced
this pull request
Mar 1, 2025
* Initial commit * Move SMODS global into `core.lua` instead of `meta.lua` * 11 more classes + HEX annotated. * Wrong file name lmao * SMODS.Sound Definition File * Full rewrite, no more "missing fields" complains * Remove `self` autocomplete, blame `@type` strictness. * whoopsie * 0.9.8 compat sushed * whoopsie + 0.9.8 compat sushed 0.9.8 compat sushed * Revert "whoopsie + 0.9.8 compat sushed" This reverts commit 936001e. * Revert `self` autocomplete removal, actually fix issue now * Re-add 0.9.8 shushing * Final bug squash before I get back to annotating classes * Additional function fixes * That should not be there * Exclude VSCode and Lua LSP settings in commits * whoopsie x2 * EVEN MORE bugfixes * Update tag.lua * Another bugfix :sadge: * Thought this was merged lmao * Actual fix xdd * Man I love doing bugfixes!!!! * How'd I miss this 💀 * Small calculate correction + SMODS.Sticker + SMODS.Stake (I think?) * SMODS.Blind * Update SMODS.Center/SMODS.Seal lsp_def files * SMODS.PokerHand + type corrections * "small" text edits (table|Class -> Class|table, better `inject_clas` desc) * Array typing corrections (totally not fixing a 2AM commit)) * Mod class Missing some internal params but those can just be ignored as long as type declaration uses `Mod|table` * SMODS.Booster.select_card * SMODS.Edition + another overhaul cause LSP discovery * whoopsie * I LOVE UNDOCUMENTED FUNCTIONS!!! + CalcContext * Small text + typing corrections * Apparently I nuked `SMODS.Back`?!?! + literal table abuse + other stuff * small arg correction * Not supposed to be there * Correction * SMODS.DeckSkin * Quantum Enhancement + BetterCalc utils * SMODS.Enhancement, SMODS.Challenge, SMODS.Suit, SMODS.Rank * Add doc links + spellcheck * Link correction * Some of loader/util + update to current * Update to current SMODS * Basically all of `utils.lua` + `game_object.lua` * Small clarifications * 95% of `ui.lua` * Bugfix + vanilla class overloading * Update game_object.lua * (Pretty sure) All modified vanilla functions * Quick bugfix * `SMODS.poll_rarity` correction * Forgor a function xdd * Bugfix + add (current) #469 functions * feat: lsp for SMODS.https * Update `cards` * `cards` fixed now, correct definition * Bugfix * Type... an unused (AND UNDOCUMENTED!) `SMODS.Edition` function? * `starting_shop` context * spellcheck :balatrojoker: * `SMODS.optional_features` + corrections * `SMODS.Sticker.sticker_sprite` annotated (forgor) * Initial `SMODS.DrawStep` API annotations ( from #480 ) * Type corrections * feat: lsp https.asyncRequest * Type + desc corrections * Missing return type * Update `post_trigger` desc * revert prev commit (pls document this) * `logging.lua` annotated * Annotate `lovely` * Annotate `json.lua` * Update + Annotate #490 * update `context.cardarea` * Update `SMODS.DrawStep` PR annotations * Desc updates + bugfixes --------- Co-authored-by: WilsontheWolf <33164598+WilsontheWolf@users.noreply.github.com> Co-authored-by: WilsontheWolf <git@shorty.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card.draw is way too annoying to deal with, so why not build an API around making it modular and allowing easy insertions anywhere during the drawing process just by specifying a numerical priority value? Well here it is I guess