Fixed a crash with entity iteration #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitRifty
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @Mikusch the extension was crashing under
Hook_Frame, an erronous usage oferasefunction was causing the iterator to go invalid.The debugging under linux was pretty terrible, due to the fact gcc/clang inlined the
Refreshfunction into the loop, so to keep things sane with compiler optimization, I've told the compiler not to inline the function and I also switched the member function ptr call inside ofRefreshto one of our helper class, both as an insurance the compiler doesn't try to offset the thisptr but also because I should have been using our helper class since the start.