Maintain column table stats in BucketRegion and use that for stats service #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 31, 2019 15:46
…f 99% for critical-heap)
Tests checking for native timer being loaded occasionally fail due to some previous tests initializing system in a different way. Now re-initialize the native timer for such a case.
- Track off-heap size in BucketRegion and add to getSizeInMemory() and getTotalBytes(). This fixes the callers of getTotalBytes() including rebalancing and determination of smallest bucket in SD layer. - Update SnappyRegionStatsCollectorFunction to avoid separate collection of off-heap size.
other cleanups
ashetkar
force-pushed
the
snappy/master
branch
from
66de320 to
2a99b53
Compare
ashetkar
force-pushed
the
optimize-columnTable-stats
branch
from
7185b67 to
16db6c5
Compare
sumwale
force-pushed
the
snappy/master
branch
2 times, most recently
from
337768c to
ec453a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
updateMemoryStats to get key and invoke ColumnBatchKey.getColumnBatchRowCount
PartitionedRegion.getNumColumns() method; removed ColumnBatchKey.getNumColumnsInTable
Patch testing
precheckin -Pstore
Is precheckin with -Pstore clean?
yes
ReleaseNotes changes
NA
Other PRs
TIBCOSoftware/snappydata#1404