-
Notifications
You must be signed in to change notification settings - Fork 75
Fix Assembly property of UnavailableType #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7f95040 to
5049968
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 259 259
Lines 16387 16387
Branches 1336 1336
=======================================
Hits 12092 12092
Misses 3878 3878
Partials 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @jpdurot, thanks for the improvement here. As soon as you've fixed the formatting issue, I'll merge this for the next version. |
|
I don't manage to find why the build is now failing after formatting one line of code... Any idea? |
The build runs on the merge of this branch with main. And in the merge, the |
The assembly was the one in which the type was referenced instead of the assembly containing the type. Issue: TNG#430 Signed-off-by: Jean-Philippe Durot <jeanphilippe.durot@gmail.com>
8c677ef to
615845d
Compare
|
My bad, did not notice that the file has changed on the main branch, should be good now |
Resolves #430
Fix on
UnavailableType.Equalsmethod was not revealed by the automatic tests but from usage with my real assemblies(Equals calls itself leading to an infinite loop).