Skip to content

Conversation

@jpdurot
Copy link
Contributor

@jpdurot jpdurot commented Nov 20, 2025

Resolves #430

Fix on UnavailableType.Equals method was not revealed by the automatic tests but from usage with my real assemblies(Equals calls itself leading to an infinite loop).

@jpdurot jpdurot force-pushed the unavailabletpye-assembly branch from 7f95040 to 5049968 Compare November 20, 2025 23:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.79%. Comparing base (2c1cbbc) to head (28708af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files         259      259           
  Lines       16387    16387           
  Branches     1336     1336           
=======================================
  Hits        12092    12092           
  Misses       3878     3878           
  Partials      417      417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderlinne
Copy link
Collaborator

Hi @jpdurot, thanks for the improvement here. As soon as you've fixed the formatting issue, I'll merge this for the next version.

@alexanderlinne alexanderlinne added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 28, 2025
@jpdurot
Copy link
Contributor Author

jpdurot commented Dec 12, 2025

I don't manage to find why the build is now failing after formatting one line of code... Any idea?

@alexanderlinne
Copy link
Collaborator

I don't manage to find why the build is now failing after formatting one line of code... Any idea?

The build runs on the merge of this branch with main. And in the merge, the Equals(UnavailableType) method is actually duplicated. Since the sign-off is missing on the formatting commit, maybe you could just squash and rebase your changes onto the current main?

The assembly was the one in which the type was referenced
instead of the assembly containing the type.

Issue: TNG#430
Signed-off-by: Jean-Philippe Durot <jeanphilippe.durot@gmail.com>
@jpdurot jpdurot force-pushed the unavailabletpye-assembly branch from 8c677ef to 615845d Compare December 15, 2025 13:40
@jpdurot
Copy link
Contributor Author

jpdurot commented Dec 15, 2025

My bad, did not notice that the file has changed on the main branch, should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnavailableType does not provide the correct assembly

3 participants