-
Notifications
You must be signed in to change notification settings - Fork 75
Record method call generic argument types as dependencies #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record method call generic argument types as dependencies #437
Conversation
cd58b9c to
af12f16
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 259 259
Lines 16387 16387
Branches 1336 1336
=======================================
Hits 12092 12092
Misses 3878 3878
Partials 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
af12f16 to
b6e8984
Compare
Signed-off-by: Pete Forrest <petemforrest@gmail.com>
b6e8984 to
da5d0d6
Compare
|
Not sure if this is the best implementation approach of this, having not contributed to this project before. Welcome any feedback. |
|
👍 We've just started to trial ArchUnitNET and one of our initial speedbumps was that generic arguments were not picked up as dependencies. |
Signed-off-by: Pete Forrest <petemforrest@gmail.com>
0f7133a to
a942f6a
Compare
Signed-off-by: Pete Forrest <petemforrest@gmail.com>
a942f6a to
ed98f4e
Compare
alexanderlinne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to propose a fix for this @Itzalive. I've left a few comments, happy to discuss if you don't agree with something.
ArchUnitNETTests/Fluent/Syntax/Elements/ObjectSyntaxElementsTests.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Pete Forrest <petemforrest@gmail.com>
5037e30 to
b8538f9
Compare
Signed-off-by: Pete Forrest <petemforrest@gmail.com>
b8538f9 to
ce1fb2e
Compare
Signed-off-by: Pete Forrest <petemforrest@gmail.com>
|
Thanks for the feedback - it's a much smaller change now and more the size it should be. And I figured out csharpier to stop all those force pushes 😆 |
Resolve an issue where generic arguments in method calls are not considered dependencies.
The helps validate modular architecture, especially for dealing with ioc containers where the types are all generic arguments.
e.g.
services.AddTransient<IMyService, MyService>();serviceProvider.Resolve<IMyService>()