Skip to content

Fix #40 + other minor improvements #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pietercolpaert merged 8 commits into from
May 23, 2025
Merged

Fix #40 + other minor improvements #41

pietercolpaert merged 8 commits into from
May 23, 2025

Conversation

@julianrojas87
Copy link
Contributor

@julianrojas87 julianrojas87 commented May 22, 2025

This PR fixes #40 and adds few minor features for generating mermaid diagrams such as:

  • Use sh:targetClass value (if available) as label for a node element
  • Use sh:datatype value (if available) as label for literal boxes
  • Improve error handling of mermaid CLI
  • Adjust and extend unit tests accordingly

@pietercolpaert pietercolpaert merged commit 1dfd419 into main May 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietercolpaert pietercolpaert Awaiting requested review from pietercolpaert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mermaid diagrams are not rendered properly

3 participants

@julianrojas87 @pietercolpaert