Skip to content

Fix variable substitution mistake #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffmaki merged 5 commits into from
Mar 20, 2025
Merged

Fix variable substitution mistake #31

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b22a16
Merge pull request #26 from TaskarCenterAtUW/dev
jeffmaki Mar 18, 2025
f0251df
Parameterization to prepare for deployment to prod
jeffmaki Mar 18, 2025
445b1ae
Prepare prod image build
jeffmaki Mar 20, 2025
6f263a4
Update build.yaml
jeffmaki Mar 20, 2025
27f7073
Merge branch 'dev' into main
jeffmaki Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
env:
ENV: ${{ vars.ENV }}
CODE_VERSION: ${{ github.sha }}
ENV_NAME_PARAM: "${{ vars.ENV == 'prod' && '' || -${ENV} }}"
ENV_NAME_PARAM: "${{ vars.ENV == 'prod' && '' || -${{ENV}} }}"

# hosts
WS_DOCKER_REGISTRY: ${{ vars.WS_DOCKER_REGISTRY }}
Expand All @@ -62,7 +62,7 @@ jobs:
env:
ENV: ${{ vars.ENV }}
CODE_VERSION: ${{ github.sha }}
ENV_NAME_PARAM: "${{ vars.ENV == 'prod' && '' || -${ENV} }}"
ENV_NAME_PARAM: "${{ vars.ENV == 'prod' && '' || -${{ENV}} }}"

# machine to deploy to
AZURE_DOCKER_HOST_IP: ${{ vars.AZURE_DOCKER_HOST_IP }}
Expand Down