Use SSH flag for cloning UMC, use HTTPS by default #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cam72cam Apologies for the second nag, but would you also be able to review this? |
Contributor
Author
|
@cam72cam Any chance I could get a review on this? 😅 |
Contributor
Author
|
@cam72cam Yearly request for a review :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes two things. Firstly, it clones GIT repositories using HTTPS by default. Secondly, it uses the preferred cloning method when cloning UMC.
My reasoning for changing the default to HTTPS is that it doesn't require any setup. To clone using SSH you need to have SSH keys setup with GitHub, which not everyone might have. To clone using SSH,
sshcan be passed in as the second argument.The second is simply a fix to ensure UMC gets cloned using SSH if requested.