Add exception handling to reduce the types of data that can be returned & tests #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeddiO
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially prevent the
withblock from returning an exception, and returnFalse, meaning the only values that should ever be returned are a SteamID64 (string) orFalse. The exception is still output via the logger as a warning type.In a future release I might split these out to two separate return values to tighten up typing.
Also added some basic unit tests testing from 3.8 upwards. We should likely bump the minimum version to 3.9 or above soon to take advantage of native type hinting, but for the time being happy to officially leave it as 3.6 support and above.
Also added a GH:A to ensure these tests run fine and dandy.